Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Trie #2355

Open
wants to merge 41 commits into
base: weiihann/improve-state-trie
Choose a base branch
from
Open

Refactor Trie #2355

wants to merge 41 commits into from

Conversation

weiihann
Copy link
Contributor

@weiihann weiihann commented Dec 31, 2024 •
edited
Loading

This PR introduces a complete new Trie implementation. Some of the major changes:

  • Separation of node types - Makes code more intuitive, reduce redundant storage, separation of concerns, easier to extend functionalities
  • Performance Optimization - Stores trie in-memory, cache node hashes, Trie.Update + Trie.Commit is 4x faster
  • Range Proof - Solves the edge case of gapped range proof from the previous implementation

This PR is a standalone package and has not been integrated with the other parts of Juno. The integration and replacement of legacy trie implementation will be given in another PR.

Also, do note that the implementation of BitArray is exactly the same as before, please ignore it during the review process.

weiihann added 30 commits January 23, 2025 10:10
@weiihann
add bytes benchmark
95eb762
@weiihann
add Rsh test
0eef3f9
@weiihann
add Truncate
83f3040
@weiihann
all tests passed
1a4d9cb
@weiihann
improve comments
dc9db08
@weiihann
minor chore
c4180f8
@weiihann
improvements
7adc66c
@weiihann
Implement trie nodes
7f3e959 
use hashFn
@weiihann
Update() works on TrieD
51035d3 
d
@weiihann
add docs
7e9b3fc
@weiihann
Add hasher
e59b988
@weiihann
add tracer
829d2ca
@weiihann
Add package trienode
2ca265c
@weiihann
Add collector
6a6140c
@weiihann
Add Trie.Commit
b16ed8c
@weiihann
add Clear() to OrderedSet
442712c
@weiihann
implement triedb
bb30169
@weiihann
rename trie/utils to trie/trieutils
85856de
@weiihann
minor changes on trienode
ff68b00
@weiihann
add trie id
9d10236
@weiihann
...a bunch of changes
2dcdec6
@weiihann
bitarray changes
d424a6a
@weiihann
bitarray changes
9e52792
@weiihann
at this point range proof tests pass 50%
93c5a92
@weiihann
still failing
6d0fd13
@weiihann
pass base test but got nil dereference bug
2444788
@weiihann
fix invalid non existent proof
59e8426
@weiihann
fix hasRightElement
84f95a9
@weiihann
create TrieDB interface
d049c76
@weiihann
range proof test cases all pass
cefc0d9
@weiihann weiihann changed the base branch from main to weiihann/improve-state-trie January 23, 2025 03:51
@weiihann weiihann marked this pull request as ready for review January 23, 2025 04:42
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 72.07403% with 513 lines in your changes missing coverage. Please review.

Project coverage is 74.33%. Comparing base (4d99dd0) to head (7ef23f2).

Files with missing lines Patch % Lines
core/trie2/proof.go 67.58% 103 Missing and 38 partials ⚠️
core/trie2/trieutils/bitarray.go 73.58% 134 Missing and 6 partials ⚠️
core/trie2/trie.go 79.43% 57 Missing and 16 partials ⚠️
core/trie2/node_enc.go 60.55% 29 Missing and 14 partials ⚠️
core/trie2/node.go 44.23% 29 Missing ⚠️
core/trie2/triedb/database.go 59.70% 21 Missing and 6 partials ⚠️
core/trie2/id.go 32.35% 23 Missing ⚠️
core/trie2/trienode/nodeset.go 72.22% 10 Missing and 5 partials ⚠️
core/trie2/hasher.go 90.66% 6 Missing and 1 partial ⚠️
utils/orderedset.go 0.00% 6 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@                       Coverage Diff                       @@
##           weiihann/improve-state-trie    #2355      +/-   ##
===============================================================
- Coverage                        74.69%   74.33%   -0.37%     
===============================================================
  Files                              111      123      +12     
  Lines                            12581    14418    +1837     
===============================================================
+ Hits                              9398    10718    +1320     
- Misses                            2484     2914     +430     
- Partials                           699      786      +87

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@weiihann